RFE: improve accessibility of code review for screen reader users

[vojtapolasek]

Select Topic Area

Product Feedback

GitHub Feature Area

UI/UX

Body

Hello,
I am a screen reader user. When doing a code review for example on this site:
https://github.com/ComplianceAsCode/content/pull/12127/files

then each file is reperesented as a table. That is great. Also I noticed that the table has three columns: first two columns represent line numbers of diffed file, and the third line represents the line content.
This is very useful because screen reader user can move cell by cell in all four directions.
However, the third column contains also the "comment" button. This is quite impractical because at the begining of every line, the screen reader announces "Add line comment button". This is very disturbing and it decreases efficiency. Do you think you could put the button into a separate column so that one column contains the line content only?
Thank you.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[cehfisher]

Hello @vojtapolasek - thank you for your feedback! We genuinely appreciate your input.

I reached out to the GitHub accessibility team regarding your question. It seems like the issue isn't a WCAG failure but more of a usability concern. The suggested solution of moving the "add line comment" button to its own column on the right makes sense from an HTML perspective and could enhance the user experience. While it may not violate WCAG guidelines, addressing such awkwardness could still improve the overall accessibility by making the interface more intuitive and user-friendly.

While this specific request isn't actively being worked on at the moment, we have added it to our internal feature tracking system for potential future development. We encourage you to check our public roadmap for insights into the projects we're focusing on this year. Please note that smaller fixes might not always be explicitly listed but could be addressed during related work.

As a valued GitHub user, your feedback in this Discussion space, complete with relevant tags and examples, is instrumental in shaping GitHub's development. While we can't guarantee immediate action on every suggestion, please know that we are attentive to your input and always working to enhance the GitHub experience.

Once again, thank you for sharing your thoughts with us, even if this particular request isn't currently in active development. Your input is crucial and contributes to the continuous improvement of GitHub!