Invalid actions-nsg-deployment.bicep for private networking for GitHub-hosted runners

[tpcgold]

Select Topic Area

Bug

Body

I've noticed that the actions-nsg-deployment.bicep is not working properly.
It seems not all IP ranges are in this configuration:
https://docs.github.com/en/organizations/managing-organization-settings/configuring-private-networking-for-github-hosted-runners-in-your-organization#configuring-your-azure-resources

The runner is online and is assigned to the GitHub Actions Workflow (if runs-on: group is selected it finds the correct runner), but the job is never picked up.
https://docs.github.com/en/organizations/managing-organization-settings/troubleshooting-azure-private-network-configurations-for-github-hosted-runners-in-your-organization

I noticed that if DenyInternetOutBoundOverwrite is not there so ANY -> INTERNET is possible the job runs successfully. Hence, the Documentation and IP ranges are off.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[tpcgold]

accoring to the flowlogs these are some of the blocked ip ranges:

                                "1723550264,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550265,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550266,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550267,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550268,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550269,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550271,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550274,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550275,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550275,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550276,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550277,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550278,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550279,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550281,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550284,10.26.2.11,185.125.188.55,58262,443,T,O,D,B,,,,",
                                "1723550284,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550285,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550285,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550286,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550287,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550288,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550289,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550291,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550292,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550293,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550293,10.26.2.11,185.125.188.58,44204,443,T,O,D,B,,,,",
                                "1723550294,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550294,10.26.2.11,185.125.188.55,39154,443,T,O,D,B,,,,",
                                "1723550295,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550295,10.26.2.11,185.125.188.55,39154,443,T,O,D,B,,,,",
                                "1723550295,10.26.2.11,185.125.188.59,43400,443,T,O,D,B,,,,",
                                "1723550296,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550296,10.26.2.11,185.125.188.55,39154,443,T,O,D,B,,,,",
                                "1723550297,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,",
                                "1723550297,10.26.2.11,185.125.188.55,39154,443,T,O,D,B,,,,",
                                "1723550298,10.26.2.11,185.125.188.55,39154,443,T,O,D,B,,,,",
                                "1723550299,10.26.2.11,20.85.130.105,37586,443,T,O,D,B,,,,"

most of them are Canonical, but there are also some Microsoft ones (e.g.20.85.130.105).
According to the metadata api:
https://api.github.com/meta

20.85.128.0/17 should be an actions ip and added to the documentation.

[tpcgold]

seems just adding
"20.85.130.105/32"
to the bicep works in my case, but I think the bicep template should use the proper CIDR ranges like 20.85.128.0/17 (according to metadata) includes this IP.

[nf-jst]

I ran into the same issue. Thanks for posting your solution - it worked! I hope the docs get updated based on your post.