Connection objects should have fewer nullable fields #139032
Replies: 1 comment
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Product Feedback
Body
I'm using
graphql-codegen
to get Typescript types for the return values of queries to Github, using https://docs.github.com/public/fpt/schema.docs.graphql as the schema. I've noticed that, for example, in arepository(...){issues(...) {nodes{...}}}
query, theresult.repository.issues.nodes
field can be null, and if it's not, then elements of that array can be null. The meaning of that result isn't addressed in the documentation, and I hope it's impossible. If it is impossible, I think thenodes
field should be typed asnodes: [Issue!]!
rather than the currentnodes: [Issue]
.Every Connection and Edge type has this issue, and it'd be nice if someone at Github would check if null results are actually possible, and if not, tighten up the schema.
Beta Was this translation helpful? Give feedback.
All reactions