License file matching oversights

[moritztim]

Select Topic Area

Bug

Body

I noticed that the license file name matching isn't fully thought out and excludes some more and some less extreme edge cases. See all three branches of https://github.com/moritztim/License-Matching-Bug-Demo, particularly https://github.com/moritztim/License-Matching-Bug-Demo/tree/examples

Note

Some of the permutations aren't displayed because GitHub doesn't seem to differentiate case when the filenames are otherwise identical.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[moritztim]

Workaround:
Make sure your license file matches this approximation of the closed source matching algorithm:

^[Ll][Ii][Cc][Ee][Nn][SsCc][Ee](?:(?:-[^.]*)?(?:\.[^.]*)?)?$

[moritztim]

The client side matching for the Choose a license template button at file creation is also inconsistent:

[moritztim]

After some experimentation, I conclude that the main issue is that no more than one dot is allowed in the filename. There also seems to be some hard to recreate unpredictable behavior when changing a license file name, maybe something to do with caching. I think the responsible piece of code needs a do-over.