New colorblind themes are much worse than normal ones

[Esaron]

Select Topic Area

Product Feedback

Body

I have mild protanopia, and upon enabling the new dark theme made for the condition, I realized that it's significantly harder to tell apart certain colors. Specifically, the new color used for the "Open" tag is completely indistinguishable from the crossmarks for failed checks. With my previous theme (Dark Dimmed), the colors are way easier to tell apart.

Example:

Dark Protanopia & Deuteranopia

Dark dimmed

[jge162]

You should definitely avoid the new theme

[Esaron]

That's the plan - it clearly isn't working for me. I just wanted to raise the issue in the hopes that maybe it improves. The blue checkmark vs new crossmark is really helpful. I just don't expect to see the same color for something positive/harmless (Open PR) and something negative (Failed/missing check).

[Esaron]

After using a color dropper, I realize that this isn't my condition, those colors really are the same... I don't expect to see the same color for something positive/harmless (Open PR) and something negative (Failed/missing check). Is this intended? Or should the "Open" tag be blue instead, like the checkmark? I'm guessing that color is used already for merges, but could the "Open" tag at least be green like it was before? That would be better than just picking the same color as a failing check.

[jge162]

I hope they see this and can make updates

[ghostinhershell]

Hi @Esaron and welcome to the GitHub community!

We appreciate you sharing your feedback on the new dark theme. I'll go ahead and loop in my colleague @benjiallen into this conversation. He may have additional questions for you.

Cheers!

[jordan-rddi]

I want to express a similar concern about the "Open" tag. The red seems like the wrong choice and doesn't appear to follow the rest of the interface either.

Another "tag" related problem I have noticed however is that the "Open" and "Closed" tags are both blue in the Projects interface when using the "Dark Protanopia & Deuteranopia" theme. However, they are blue and green when using "Dark default".

Dark Protanopia & Deuteranopia

Dark default

However, as a side note, I have to say the colourblind themes are a godsend for PR change comparisons and I will continue to use these themes just for that.

[cehfisher]

Hello @Esaron - thank you for providing this feedback! We will file this with our Accessibility team so that it can be reviewed and will follow-up here with any additional questions or updates. Thanks again!

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[cehfisher]

Hello @Esaron,

I reached out to the GitHub accessibility team about your question. While they aren't currently working on a fix for this issue, it's been added to our internal feature tracking system for potential future development. We encourage you to check our public roadmap for insights into our focus this year, though smaller fixes might not be explicitly listed.

Your feedback is instrumental in shaping GitHub's development, and while we can't guarantee immediate action on every suggestion, we're always attentive to improving the GitHub experience.

Thank you again for sharing your thoughts, even if this request isn't in active development. Your input is invaluable and helps us continuously enhance GitHub!

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬