[Issue] failed matrix jobs with continue-on-error count as success for subsequent jobs

[scrungus]

Select Topic Area

Question

Body

given a ci job:

name: test and publish
on:
  push:

jobs:
  test:
    uses: ./.github/workflows/test.yaml
    secrets: inherit

  publish:
    needs: [test]
    uses: ./.github/workflows/publish.yaml
    secrets: inherit

If test.yaml is setup like so:

name: Test
on: 
  workflow_call:

jobs:
  test:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        version: [1,2,3,4]
      max-parallel: 1
    continue-on-error: true 
    steps:
      - name: Fail
        run: exit 1

Then the publish job will start even if the test job fails. In our use case, the desired behaviour is that all the test jobs in the matrix should run, regardless of any failures, but publish should not run if all the test jobs do not complete successfully. Is there currently a way to do this, and is this the indented behaviour of continue-on-error?

[airtower-luna]

Remove continue-on-error (or set it to false), and set fail-fast: false instead. That way one failing matrix job won't cancel the others, but errors won't be ignored. See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

[airtonix]

this is the way

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬