GitHub Community
Accessibility improvements for the contribution graph #49015
Replies: 5 comments 9 replies
-
@glorialangreo 8 days per week, nice |
Beta Was this translation helpful? Give feedback.
-
|
I am excited for these changes. For the first time, a screen reader user can consume the content. Thank you! As I am sure you are aware, there are still some outstanding issues. Some of them I outlined in https://github.com/orgs/community/discussions/17281. The charts are still broken for users in Windows High Contrast Mode / Contrast Themes (which maps to The tool-tips still have the 1.4.3 issues I identified in the other request / issue / question / discussion (text cannot be selected, do not dismiss without moving pointer/focus). I also feel the left column headers should probably be fixed since they scroll out of the container view: Finally, I think the screen reader labeling might be a bit verbose. The instructions to use the table as exposed in NVDA (NVDA 2022.4 with Firefox 110) are so long they require an extra key press to complete. I made a transcript (with keyboard interactions):
That is a lot of listening to get to the first cell. Here is a transcript from JAWS (JAWS 2023 with Chrome 110) to activate one of the dates:
A lot is announced when moving in and out of the table. I think instead of giving each cell a verbose name you could use the row and column header to provide the month and day, and then lead with the number of contributions (and maybe leave that word out altogether). At least for the context of supporting screen reader table navigation. But I defer to the results of formal testing with screen reader users who are also GitHub users. |
Beta Was this translation helpful? Give feedback.
-
|
@jamieshark I am checking to see if this is in development and, if so, when you expect it some of your updates will be available. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @aardrian - sorry for the delay. I was focused on different work, but now am back on working on this. Expect an update by this week, thanks for checking back in. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @aardrian! I'm working with @ericwbailey to address the concerns you've brought up here. Some of them are easier fixes and others are trickier so I can't say for sure exactly when changes will be released, but we're aiming to have updates rolled out within the month or so. Thanks again for your patience while we tinker with this feature. |
Beta Was this translation helpful? Give feedback.
-
|
@jamieshark Thanks for the update! I look forward to seeing them. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @aardrian! I'm an engineer on @jamieshark's team who has been working on the contribution graph recently. First, thank you so much for all of your thoughtful and detailed feedback. Your time and expertise is valuable, and we're so grateful that you invested time to let us know how we could be doing better. I wanted to update you about some recent changes we've shipped to the contribution graph. Support for high contrast mode We've updated the contribution graph to use the size of the squares as an indicator of contribution intensity when a user has forced-colors mode enabled. Improved tooltip behavior The tooltips triggered by hovering over or focusing a grid cell in the contribution graph are now selectable and dismissible without changing the user's focus. Updated screen reader content while navigating the grid We've updated the information that is announced by screen readers as users navigate the graph. We've removed the repetitive descriptions of the grid, and updated the announced content to include how many contributions were made on the focused date, and how that number fits into the user's overall contributions trend. ie:
We’ve also added descriptive text to the activity overview spider graph, so that screen readers can announce how a user’s contributions are broken down between commits, pull requests, issues, and code review. Improved year selection behavior for mobile users and users who browse at 200% zoom We’ve updated the profile page to always display a year picker, so that users on smaller layouts can view contribution history for a given year on any screen size. |
Beta Was this translation helpful? Give feedback.
-
|
hey i have a problem with this i have commit in a projet but my calendar is not update |
Beta Was this translation helpful? Give feedback.
-
|
is it the default branch? |
Beta Was this translation helpful? Give feedback.
-
I |
Beta Was this translation helpful? Give feedback.
-
|
Has this rolled out yet? I ask because when I navigate with JAWS/Chrome, I cannot get into the cells. The column and row headers announces as graphics. Which makes sense since the entire thing is an SVG with no roles. It also doesn't seem to use system colors when I activate Windows Contrast Themes. The WCAG contrast issues among the different cells are still there of course, but now I can enjoy them when I try to force them to WHCM! NVDA/Firefox at least considers it a table and I can get into the cells, but when I get to a cell I hear "column 27 selected clickable 4 contributions on Monday, December 19, 2022". Oh, I see now, I am being served an HTML table in Firefox. Oh, wait, I get it. The SVG is for the logged-out view and the table is for the logged-in view. And yup, the Contrast Themes output is the same as before. And JAWS announces as "4 contributions on Monday, December 19, 2022 I don't think the verbosity in the cells has dropped. But the non-screen-reader keyboard navigation improvements are nice. Sorry this is stream-of-consciousness, I am in post-dinner lethargy. |
Beta Was this translation helpful? Give feedback.
-
|
Still working on it @aardrian!! Or rather, there have been some other things that have taken priority before this, but we are planning out the changes and work for the upcoming months. Thanks for your patience, and I promise that this is something that's been top of mind for me since it's been brought up. |
Beta Was this translation helpful? Give feedback.
-
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
The contribution graph now supports keyboard interaction and compatibility with assistive technologies. Users can navigate the graph and filter contributions using the keyboard. While navigating the graph, a summary of each day is displayed visually in a tooltip and announced by screen readers.
Users can move keyboard focus to the contribution graph and then navigate it using the following commands:
If the user is running a screen reader, it will announce the following text when the graph receives keyboard focus:
When the user navigates to a cell, the screen reader will read a summary such as:
We are excited to make one of our favorite GitHub features available to more users! If you encounter any issues with these changes, please leave a comment here.
Beta Was this translation helpful? Give feedback.
All reactions