Keyboard shortcuts for saved replies do not work the first time

[AlCalzone]

Select Topic Area

Bug

Body

When accessing saved replies using keyboard shortcuts (CTRL + . -> CTRL + 1), actually selecting the reply using the second shortcut does not work the first time. The dialog needs to be closed and reopened for this to work.
This breaks every time after navigating to a new page, or reloading a page with a text field.

To reproduce:

1. Open a text field, like on issues/PRs/discussions
2. Press CTRL + .
3. Press CTRL + 1 to select the first reply
4. (... nothing happens ...)
5. Close the dialog
6. Press CTRL + .
7. Press CTRL + 1 to select the first reply
8. (... saved reply is inserted ...)

[jeana-redhat]

This started happening when the Saved replies menu was changed from a drop-down to a pop-up for me. Really bad usability regression.

[ghostinhershell]

Hey there @AlCalzone and @jeana-redhat,

Thanks so much for sharing your feedback and reporting this issue. I'll test this out on my end and follow-up with the Accessibility team so that they can review.

[jeana-redhat]

@ghostinhershell thanks!

In case it's helpful info, for me this is in Firefox on Linux

PS great username 😀

[jeana-redhat]

Today, this is fixed for me 🎉

I still have the new pop-up UI, but now:

1. Hit Ctrl + .
2. Saved replies menu pop up.
3. Hit Ctrl + 1
4. First saved reply is populated into the comment field and the pop-up disappears

This functions correctly, even on the first attempt (no need for close/reopen workaround as before).

Cheers to whoever got the fix in so quickly! Hope the original reporter is also seeing it working for them 🤞

[AlCalzone]

Looks like this is solved. Thanks!

[AlCalzone]

@ghostinhershell recently this is broken for me again.

[jeana-redhat]

Yep, same for me 🤔

[cehfisher]

Hi @AlCalzone - thank you for providing this feedback! We wanted to follow up on this reported bug. Is this still an issue? If it is resolved, could you please close out this issue? If it is not resolved, we can file this as a new issue for the Accessibility team to review. Thank you! (cc @queenofcorgis)

[AlCalzone]

It's still happening sometimes. I think this might be a race condition. I noticed that this happens when the saved replies are loaded and appear after a short delay after the loading spinner.
When they appear immediately, it usually works.

[cehfisher]

Thank you for providing this additional feedback! We will file this with our Accessibility team so that it can be reviewed and will follow-up here with any additional questions or updates. Thanks again!

[AlCalzone]

Any information I can collect for you when it happens, that can help fix this? I'm running into this regularly, but I haven't really been able to make sense of it.

[JoeEasy254]

#126107

[AlCalzone]

I hate to say it, but this feature is broken again for me. The CTRL+number shortcuts don't work at all in the current Firefox right now.

[jeana-redhat]

Noticed this in Firefox yesterday as well.

[cehfisher]

Sorry to hear about this regression! We will update the internal issue and get back with any updates or follow-up questions.