GitHub Community
"Viewed" checkbox on bottom of diff #9676
Replies: 2 comments 4 replies
-
|
Similar discussion - https://github.com/github/feedback/discussions/4759 +1 from me. It would be a nicer flow - read through the code, and click a checkbox at the bottom of the file. |
Beta Was this translation helpful? Give feedback.
-
|
similar discussion link gives 404. but +1 on dupe checkbox at bottom request |
Beta Was this translation helpful? Give feedback.
-
|
From what I can tell, this is a Firefox-specific issue (either that or they're A/B testing something). I have the same PR open in chrome and Firefox. In chrome, the "viewed" checkbox hovers at the top of the window, so is always easily clickable. In Firefox it doesn't and I have to scroll up. |
Beta Was this translation helpful? Give feedback.
-
|
can't confirm.. chrome/mac file headers scroll up off page (Jan 2023) |
Beta Was this translation helpful? Give feedback.
-
|
as of a few days ago I also get this on chrome that the "viewed" checkbox is no longer sticky! |
Beta Was this translation helpful? Give feedback.
-
|
On firefox 132 (linux) here and it started scrolling out of view at some point last few days (haven't been at this computer for a week). |
Beta Was this translation helpful? Give feedback.
-
When we have long diffs in a PR, after reviewing them, if we want to mark the diff as viewed, we have to go all the way back to its top to click on the checkbox. I think it could be really useful if the checkbox were moved, or duplicated, to the bottom of the diff.
Beta Was this translation helpful? Give feedback.
All reactions