Add "Favorites" to connect dialog

[dcorson-ticino-com]

My first attempt to add favorites by making the connect dialog tabbed and having a similar display to the existing server list for the favorites turned out to be a very big code change. I am now thinking through how to do a "minimally invasive" favorites feature.

Present thoughts are for the following:

1. in the connect dialog rename the "Server Address" combobox to "Favorites"
2. add a button to the dialog "Add to Favorites"
3. the combobox retains the possibility to add entries manually, clicking the Add to Favorites button puts the entry selected in the server list in the combobox list.
4. maybe it would be useful to bring the last used entry of the combobox to the top of the list each time.
5. as the favorites list has a determined length the oldest unused entry eventually falls off the end of the list. Entries can also be removed with a mouse right click.

What do you think? Does that fulfill the needs for Favorites? What could be improved?

[gilgongo]

(I took the liberty of numbering your points so they can be referenced, sorry)

Assuming the dialogue you refer to in 2 is the connect window, then would someone take the decision to make a server a favourite before they joined it? I would have thought it was more logical to make that decision after they had joined and read any welcome message or licence notice. In which case, that implies a "favourite" function would be available from the main window, perhaps?

4 seems sensible.

BTW I think the context menu for removing is the wrong decision, since it's literally the only Jamulus function we have on right click. So if somebody finds it, they will be forever right-clicking around the app wondering if there are other hidden functions. Best practice with context menus is to have all (or a constant subset) of functions available, or none. Better in this case to have simply had a delete icon (with explanatory tool tip) next to the current entry in the input field I think.

[gilgongo]

I meant it's the only Jamulus function we have on right click. We should have them consistently for all relevant contexts if we have them at all, because that's what context menus are for (so right-click on a fader, get mute, solo, group, help etc. Right-click on another item get help on its own, etc.). We don't really have enough contexts to warrant their use though, even if we do get them "for free" from the OS/Qt on fields (which deploys them consistently for fields, as you point out). Occasional "hidden" context commands are not good design when more usable alternatives are available.

[dcorson-ticino-com]

Does this mean you plan to enable the Server Address combobox to accept either server names or IP addresses?

Yes, you can enter an IP or URL, but Add to Favorite places a server name. It won't work if you type in a server name as that won't give the also needed IP (that is stored, but hidden).

Maybe this isn't such a good idea after all to overload the Server Address field with the Favorites. A separate combobox may be a better solution.

[dcorson-ticino-com]

so right-click on a fader, get mute, solo, group

I don't follow you. Why would I right click on something to get a function that is already there ? I right click to find functions that are not the every day obvious stuff that already has its own UI manifestation.
Most of the controls already have "What's this" on right click. It's not like we never use a right click.

[gene96817]

Maybe this isn't such a good idea after all to overload the Server Address field with the Favorites.

I agree that the mixed mode could confuse a non-technical user.

[gilgongo]

Why would I right click on something to get a function that is already there?

Exactly my point :-) Apps that have context menus (eg drawing tools) typically have large numbers of functions, some of which are applicable to specific contexts, and users use them all the time. We have very little of that, so we shouldn't be adopting a convention just for one thing when a clear alternative is available just like all our other functions (buttons, links). If one Jamulus feature is "hidden" in a context menu, how does the user know whether there are others elsewhere?

This is what I meant about the delete on the drop-down BTW.

delete-demo.mp4