Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command): add timeout for terminating process #227

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Jun 20, 2024

Description

This PR adds a new command line argument (--timeout) for terminating the process if it is running more than 5 seconds.

Motivation and Context

closes #213

How Has This Been Tested?

Locally

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.99%. Comparing base (9bbcd73) to head (0ec4c0b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   75.41%   75.99%   +0.58%     
==========================================
  Files          16       16              
  Lines         671      687      +16     
==========================================
+ Hits          506      522      +16     
  Misses        165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit edb3263 into main Jun 20, 2024
17 checks passed
@orhun orhun deleted the feat/add_process_timeout branch June 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck when running on interactive prorgam (e.g. python)
2 participants