Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify padding type? #250

Open
cassc opened this issue Nov 28, 2017 · 3 comments
Open

How to specify padding type? #250

cassc opened this issue Nov 28, 2017 · 3 comments

Comments

@cassc
Copy link

cassc commented Nov 28, 2017

How to specify SAME/VALID padding with cortex.nn.layers/convolutional similar to conv2d in tensorflow

Thanks for you great work!

@cnuernber
Copy link
Contributor

Currently you can only specify the exact padding amount. So same padding for a kernel size of 3 is 1, not sure what valid means in this context.

We would have to add this feature in order to allow this; I would be in favor for sure but we need to know the exact math in both the even and odd kernel dimension cases.

@maxc01
Copy link

maxc01 commented Jan 5, 2018

In TF, VALID padding means one should "specify the exact padding amount". From my point of view, it is not necessary to implement SAME padding from an API level, because one can always compute the padding to ensure the same spatial size not that difficult. For computing padding, A guide to convolution arithmetic for deep learning [1] is a great reference.

[1] https://arxiv.org/abs/1603.07285

@cnuernber
Copy link
Contributor

Thanks, that is indeed a great reference!

All of our kernel/padding specifications are completely manual at this point so I guess we default to 'valid'.

Again, thanks for the paper I agree completely that it is a great reference and it includes some description of various deconv techniques which are always interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants