Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print button not really disabled #1661

Closed
johnnyblasta opened this issue Jan 30, 2023 · 3 comments · Fixed by #1663
Closed

Print button not really disabled #1661

johnnyblasta opened this issue Jan 30, 2023 · 3 comments · Fixed by #1663
Assignees
Labels

Comments

@johnnyblasta
Copy link
Collaborator

Describe the bug
The buttons in print for saving image and create pdf isn't really disabled while loading the map. The buttons looks diasbled while loading the map , but they can stil be clicked on and will create a map which isn't fully loaded.

To Reproduce
See animation of problem:
Print-button-not-working

Expected behavior
The buttons should not be clickable while the map is being loaded.

@jokd jokd added the bug label Jan 30, 2023
@jokd
Copy link
Contributor

jokd commented Jan 31, 2023

@johnnyblasta Will you have a look at this?

@johnnyblasta
Copy link
Collaborator Author

@johnnyblasta Will you have a look at this?

@Grammostola was a bit keen on looking at this, so he might solve it before I can get to it.

@Grammostola
Copy link
Contributor

Grammostola commented Jan 31, 2023

I'm having a look and can perhaps send a tentative PR later today (else I can talk about it tomorrow). There are a couple of beefs I have with what the print control is doing regardless of whether active or not.

Edit: I'll push it before our routine meeting tomorrow. It's a little bit experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants