Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event when item is added to carousel #2080

Closed
jokd opened this issue Nov 8, 2024 · 2 comments · Fixed by #2081
Closed

Event when item is added to carousel #2080

jokd opened this issue Nov 8, 2024 · 2 comments · Fixed by #2081

Comments

@jokd
Copy link
Contributor

jokd commented Nov 8, 2024

Is your feature request related to a problem? Please describe.
When an item is added to the featureinfo carousel (overlay/sidebar) an event should be dispatched, similar to what happens when the selection manager adds a SelectedItem.

@steff-o
Copy link
Contributor

steff-o commented Nov 10, 2024

At which point does SelectionManager dispatch an add event? Best I can find is getSelectedItems.on('add'), which is an OpenLayers event (yes, they are also events), but featureInfo never dispatches anything for Selectionmanager. This will lead to developers having to take care of both cases depending which infowindow is active.

@jokd
Copy link
Contributor Author

jokd commented Nov 11, 2024

At which point does SelectionManager dispatch an add event? Best I can find is getSelectedItems.on('add'), which is an OpenLayers event (yes, they are also events), but featureInfo never dispatches anything for Selectionmanager. This will lead to developers having to take care of both cases depending which infowindow is active.

Yes you are correct. The doRender function could instead dispatch the itemadded event no matter what type of infowindow is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants