Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Logging system #151

Closed
PEM-- opened this issue May 16, 2015 · 4 comments
Closed

Enhancement: Logging system #151

PEM-- opened this issue May 16, 2015 · 4 comments
Labels
type:idea

Comments

@PEM--
Copy link
Contributor

PEM-- commented May 16, 2015

Currently, Orion's logs are mixed with application logs which leads to incomprehensions from users / developers.

I propose that we use which provides a good isolation as well as levels: https://atmospherejs.com/jag/pince.

I've used it on an app and it behaves properly with Orion separating my app logs from the one of Orion.
@gam-ragnar
Copy link
Contributor

Logging is a big deal are your proposing core makes this a dependent?

@PEM--
Copy link
Contributor Author

PEM-- commented May 16, 2015

Yep. Currently, there console.log everywhere. They mix with developper's log. Thus, they can't understand if stuff is going badly owing to them or Orion.

@gam-ragnar
Copy link
Contributor

Do a PR

@PEM--
Copy link
Contributor Author

PEM-- commented Aug 15, 2015

PR done #271

😄

@PEM-- PEM-- closed this as completed Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PEM-- @nicolaslopezj @gam-ragnar