You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If ADIOS2_USE_Python is ON, and ADIOS2_USE_MPI is ON, but mpi4py is not present, configuration does not error like it should.
To Reproduce
Make sure Python development files are installed but mpi4py is not
Configure with ADIOS2_USE_Python=ON and ADIOS2_USE_MPI=ON
Observe that no error occurs
Expected behavior
An error should occur, since the required mpi4py was not found
Additional context
This appears to be due to how find_package(PythonModule) works. It handles variables for PythonModule_<module> rather than PythonModule. So when REQUIRED is passed, PythonModule_FIND_REQUIRED is set to true, but find_package_handle_standard_args() reads PythonModule_mpi4py_FIND_REQUIRED, which is not set, and so the error is not triggered.
I believe that the solution is to either change how find_package(PythonModule) works, or write a dedicated find module for mpi4py.
The text was updated successfully, but these errors were encountered:
Describe the bug
If
ADIOS2_USE_Python
isON
, andADIOS2_USE_MPI
isON
, butmpi4py
is not present, configuration does not error like it should.To Reproduce
mpi4py
is notADIOS2_USE_Python=ON
andADIOS2_USE_MPI=ON
Expected behavior
An error should occur, since the required
mpi4py
was not foundAdditional context
This appears to be due to how
find_package(PythonModule)
works. It handles variables forPythonModule_<module>
rather thanPythonModule
. So whenREQUIRED
is passed,PythonModule_FIND_REQUIRED
is set to true, butfind_package_handle_standard_args()
readsPythonModule_mpi4py_FIND_REQUIRED
, which is not set, and so the error is not triggered.I believe that the solution is to either change how
find_package(PythonModule)
works, or write a dedicated find module formpi4py
.The text was updated successfully, but these errors were encountered: