Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SST and SSC does not support Memory Selection in write side #3708

Open
pnorbert opened this issue Jul 21, 2023 · 2 comments
Open

SST and SSC does not support Memory Selection in write side #3708

pnorbert opened this issue Jul 21, 2023 · 2 comments
Assignees
Milestone

Comments

@pnorbert
Copy link
Contributor

We need SST and SSC support Memory Selection on the write side.

The Gray-Scott tutorial example is held back by the fact that only BP supports Memory Selection. We have been running the example with the old approach of double copy of data.

Example
https://github.com/ornladios/ADIOS2-Examples/tree/master/source/cpp/gray-scott

Set "adios_memory_selection": true, in input
https://github.com/ornladios/ADIOS2-Examples/blob/master/source/cpp/gray-scott/simulation/settings-files.json

gsplot.py will show that the data includes the ghost cells since memory selection is not executed.

@pnorbert pnorbert added this to the v2.10.0 milestone Jul 21, 2023
@eisenhauer
Copy link
Member

I think the question is: Are we happy with double copy (like we have in the BP5 file engine)? Or do we want to push the copy down into the serializer (actually into the MallocV buffer class) so that it only happens once? The former can happen immediately. WRT the latter, it might be the time to do it because we also need additional application-level information to handle GPU buffers for issue #3706 .

@pnorbert
Copy link
Contributor Author

SST has had support for this for a while now, but SSC still doesn't

@pnorbert pnorbert modified the milestones: v2.10.0, v2.11.0 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants