-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pugixml can't be found #4081
Comments
Interesting... Obviously a CMake issue, but not having a handy ArchLinux platform sitting around, we're unlikely to be able to duplicate it (nor do we regularly test the use of external rather than supplied packages.). Perhaps if you included the output of CMake? That would let us know if it actually found a system pugixml... |
Do you mean a config.log? I couldn't find one, but here is the shell output on Pastebin. |
Probably needs to be looked at by our CMake people. Are you looking at this because you want to use ADIOS or are you packaging? |
adios2 is already packaged for Arch Linux and it links to system pugixml with no problems, as far as I can tell 🤷 |
@lahwaacz PS: I've just noticed that you are the actual packager. I'm (terribly!) sorry for leaving the path of vanilla ArchLinux. May you be so kind and try a build with current git sources? |
@waarmond thanks for sharing this with us. Can you share your |
I am seeing the same while bumping adios2 to 2.10.0
|
2.9.2 worked well for homebrew builds before (including py3.12 build migration), the gcc 13.2.0 was used for both builds. |
2.10.0 issue was probably introduced in dd432c1 From quick glance, external if (NOT TARGET pugixml AND (NOT DEFINED PACKAGE_FIND_VERSION OR PACKAGE_FIND_VERSION VERSION_LESS "1.11"))
add_library(pugixml INTERFACE IMPORTED)
# Equivalent to target_link_libraries INTERFACE, but compatible with CMake 3.10
set_target_properties(pugixml PROPERTIES INTERFACE_LINK_LIBRARIES pugixml::pugixml)
endif () I don't know what is recommended way, but some things that work are extending scope EDIT: Looks like other changes in dd432c1 are also problematic. Even if you fix CMake scoping, build will fail when linking, e.g.
|
@cho-m thanks for the hints. It seems that to be a typo from our side, we must use the target |
I believe that this was fixed at #4135, closing this please re-open if you still have the issue. |
I'm trying since severals month to overcome the missing pugixml. The error occurs on both current git and 2.9.2
Since I'm on ArchLinux I would prefer to use system libs.
Describe the bug
To Reproduce
Expected behavior
configure, make, make install
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: