oauth2: Improve refresh security and reliability #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves several issues regarding the refresh flow. First, an issue has been resolved which caused the audience to not be set in the refreshed access tokens. Second, scope and audience are validated against the client's whitelisted values and if the values are no longer allowed, the grant is canceled. Closes #331 Closes #325 Closes #324
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
This patch resolves several issues regarding the refresh flow. First, an issue has been resolved which caused the audience to not be set in the refreshed access tokens. Second, scope and audience are validated against the client's whitelisted values and if the values are no longer allowed, the grant is canceled. Closes ory#331 Closes ory#325 Closes ory#324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves several issues regarding the refresh flow. First,
an issue has been resolved which caused the audience to not be
set in the refreshed access tokens.
Second, scope and audience are validated against the client's
whitelisted values and if the values are no longer allowed,
the grant is canceled.
Closes #331
Closes #325
Closes #324