Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jwt strategy interface mismatch #58

Merged
merged 1 commit into from
Jul 3, 2016

Conversation

jacyzon
Copy link
Contributor

@jacyzon jacyzon commented Jul 2, 2016

Validate token function only return error by interface definition, but in jwt strategy return both signature and error.

@aeneasr
Copy link
Member

aeneasr commented Jul 3, 2016

thanks!

@aeneasr aeneasr added the bug Something is not working. label Jul 3, 2016
@aeneasr aeneasr self-assigned this Jul 3, 2016
@aeneasr aeneasr added this to the v1 milestone Jul 3, 2016
@aeneasr
Copy link
Member

aeneasr commented Jul 3, 2016

Please sign the DCO. You can do so with git commit --amend -s

validate token interface mismatch in jwt strategy

Signed-off-by: Yi Zhang Chen <jz@jacyzon.com>
@jacyzon
Copy link
Contributor Author

jacyzon commented Jul 3, 2016

@arekkas signed =)

@aeneasr
Copy link
Member

aeneasr commented Jul 3, 2016

thanks!

@aeneasr aeneasr merged commit 4d0a545 into ory:master Jul 3, 2016
budougumi0617 added a commit to budougumi0617/fosite that referenced this pull request May 10, 2019
Signed-off-by: Yi Zhang Chen <jz@jacyzon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants