Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move userinfo handler from Hydra to fosite #581

Closed
mitar opened this issue Apr 9, 2021 · 3 comments
Closed

Move userinfo handler from Hydra to fosite #581

mitar opened this issue Apr 9, 2021 · 3 comments
Labels
stale Feedback from one or more authors is required to proceed.

Comments

@mitar
Copy link
Contributor

mitar commented Apr 9, 2021

Is your feature request related to a problem? Please describe.

I think userinfo handler should be part of fosite and not Hydra. I am looking at UserinfoHandler and I literally do not see anything Hydra specific. On the other hand, this would allow fosite users to roll out one more standard oauth endpoint.

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2021

The userinfo endpoint can contain any information (from db, payment systems, ...) and is fairly straight forward to implement - I don't see big upsides to having that here.

@mitar
Copy link
Contributor Author

mitar commented May 13, 2021

I mean, it is still duplicated code one has to locally maintain. I think having the basic claims being populated, with one being able to add more claims before writing it out, would be nice. Like all other handlers are. Especially if various strategies can contribute to the output of the handler, then one can even decouple which claims come from where.

So I think current handler in Hydra is maybe straight forward to implement, but if one wants to make it more general and extensible, then it would be nice to have it here.

@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants