Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_time id_token claim changed to float64 #598

Closed
narg95 opened this issue May 22, 2021 · 0 comments
Closed

auth_time id_token claim changed to float64 #598

narg95 opened this issue May 22, 2021 · 0 comments

Comments

@narg95
Copy link
Contributor

narg95 commented May 22, 2021

Describe the bug

PR #595 introduced a breaking change on auth_time claim data type in id_token. Previously the auth_time claim was of type int64 but this change transformed it to float64. Although values are still equivalent hydra tests expects an integer.

Test: TestAuthCodeWithDefaultStrategy/case=ensure_consistent_claims_returned_for_userinfo expects the auth_time

To Reproduce

  1. Checkout hydra's integration with fosite v0.40 branch from PR #2526
  2. Run
$ go test -failfast -v -short -tags sqlite -run TestAuthCodeWithDefaultStrategy/case=ensure_consistent_claims_returned_for_userinfo ./oauth2

Expected behavior

Test PASS

@narg95 narg95 changed the title auth_time id_token claim to a int64 value auth_time id_token claim changed to float64 May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant