feat: add new function to TokenRevocationStorage to support refresh token grace-period #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bill-robbins-ss
changed the title
mitar
reviewed
Nov 17, 2021
aeneasr
reviewed
Nov 19, 2021
|
Are you still up for the changes? 🧐 If you need any help, let us know! I'll convert this to a draft in the meanwhile. When it's ready for review again, please remove the draft indicator! 👀 |
|
Hey @aeneasr I was ready for a merge. What changes are requested ? |
|
@bill-robbins-ss in case you missed the comment: #635 (comment) |
|
Hey @aeneasr I got it, taking some time off before the new year then I'll catch everything up. Thanks ! |
|
Awesome! Enjoy the time off the digital world and with your family & loved ones :) Looking forward to have you back when you're back! :) |
aeneasr
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new function to the Token Revocation Storage interface that is called during a refresh token flow.
See ory/hydra#2827 for details on this feature.
Related Issue or Design Document
#255
Hydra 1831
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments