Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple deployments cause problems #55

Closed
jhutchins opened this issue Jun 19, 2020 · 2 comments
Closed

Multiple deployments cause problems #55

jhutchins opened this issue Jun 19, 2020 · 2 comments
Labels
stale Feedback from one or more authors is required to proceed.

Comments

@jhutchins
Copy link
Contributor

It appears that it is not currently possible to run multiple deployments of hydra-maester at the same time in different namespaces. The problem appears to be that all hydra-maester instances look for all oauth2client instances regardless of namespaces. It seems like like this could be resolved by allowing an optional setting for namespaces under management and then all clients outside of those namespaces would be ignored.

Maybe I'm being ignorant and there is a way to handle this without code changes, but I can't seem to figure out how.

If I'm right and a code change is required I'm happy to do the work I just need to know if @aeneasr thinks it would be better to make the filter a Predicate added to the manager in the SetupWithManager method, as a check in the Reconcile method or some other mechanism I've yet to think of.

@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2020

Yup, that makes sense to me! Contributions welcomed :)

@github-actions
Copy link

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants