Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Easily support different workflows by sharing compose configurations #1196

Closed
aaslamin opened this issue Dec 1, 2018 · 1 comment
Closed

Comments

@aaslamin
Copy link
Contributor

aaslamin commented Dec 1, 2018

Describe the solution you'd like

The current docker compose setup in Hydra makes it cumbersome to switch between various workflows (e.g. switching between mysql/postgres, setting up tracing, etc). Currently, one has to uncomment the services/configurations they are after.

Instead, we can use multiple compose files to customize the application to support a completely different workflow. This is supported by compose - https://docs.docker.com/compose/extends/#multiple-compose-files

I propose we have a default configuration with postgres, with extensions/overrides for mysql and setting up tracing via jaeger:

• docker-compose.with-mysql.yml
• docker-compose.with-jaeger.yml

For example, if I want to setup Hydra to use mysql instead AND configure tracing via Jaeger:

docker-compose -f docker-compose.yml -f docker-compose.with-mysql.yml -f docker-compose.with-jaeger.yml up

This makes it easy for people to add new workflows in the future (e.g. a setup for Prometheus).

@aaslamin aaslamin changed the title Easily support different workflows by sharing compose configurations DX: Easily support different workflows by sharing compose configurations Dec 1, 2018
@aeneasr
Copy link
Member

aeneasr commented Dec 1, 2018

Oh yeah, super nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants