Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep tests exportable #1204

Closed
someone1 opened this issue Dec 6, 2018 · 4 comments
Closed

Keep tests exportable #1204

someone1 opened this issue Dec 6, 2018 · 4 comments
Labels
feat New feature or request.
Milestone
unplanned

Comments

@someone1
Copy link
Contributor

someone1 commented Dec 6, 2018

I'm back at developing my plugin as hydra approaches its 1.0 release, however, I've noticed that the oauth2 tests (and possibly others) are no longer exported (sad)!

3a10df9#diff-88

Was there a reason behind this? I see more and more tests are being added but since I can't access them I can't ensure feature parity with the internal database implementations.
@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2018 •
edited
Loading

Just me being stupid, sorry - I forgot about you. Feel free to revert and add a note/comment to remind me not to mess it up again :)

@aeneasr aeneasr added the feat New feature or request. label Dec 6, 2018
@aeneasr aeneasr added this to the v1.0.0-rc.3 milestone Dec 6, 2018
@aeneasr aeneasr added the debt label Dec 6, 2018
@someone1
Copy link
Contributor Author

someone1 commented Dec 6, 2018

Not a problem!

I wonder if there's a way for tests to load the plugin (if present) into the database managers list when running tests, maybe that way I don't have to worry about tests being exportable and can even gain entry to any tests I've overlooked. I'll be sure to look into as I catch up with hydra over the next couple weeks!

@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2018

Sounds good, and sorry again :)

@aeneasr aeneasr modified the milestones: v1.0.0-rc.4, unplanned Dec 7, 2018
@someone1 someone1 mentioned this issue Dec 7, 2018
Merged
6 tasks
@aeneasr
Copy link
Member

aeneasr commented Dec 12, 2018

Resolved by #1212

@aeneasr aeneasr closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request.
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
2 participants
@someone1 @aeneasr