Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_conns and max_idle_conns are not removed from DSN #1327

Closed
vesvalo opened this issue Mar 27, 2019 · 2 comments
Closed

max_conns and max_idle_conns are not removed from DSN #1327

vesvalo opened this issue Mar 27, 2019 · 2 comments

Comments

@vesvalo
Copy link

vesvalo commented Mar 27, 2019

The settings max_conns and max_idle_conns are not removed from DSN string when hydra connects to Postgres.

If DATABASE_URL is set like this:

DATABASE_URL="postgres://pghost:5432/hydra?sslmode=disable&max_conns=20&max_idle_conns=4"

Hydra can't connect to the Postgres.
Postges logs:

2019-03-27 13:22:22.615 GMT [41732] FATAL:  unrecognized configuration parameter "max_idle_conns"
2019-03-27 13:22:37.629 GMT [41734] FATAL:  unrecognized configuration parameter "max_conns"
@aeneasr
Copy link
Member

aeneasr commented Mar 28, 2019

Please use the issue templates. Crucial information is missing, like software version, command you executed, and so on. This issue will auto-close otherwise.

@vesvalo
Copy link
Author

vesvalo commented Mar 28, 2019

Command to run:

export DATABASE_URL="postgres://pghost:5432/hydra?sslmode=disable&max_conns=20&max_idle_conns=4"
hydra serve all --dangerous-force-http

Environment, software version: kubernetes, docker image hydra:v1.0.0-rc.6_oryOS.10-alpine

The issue was addressed in the #464, but that fix is not present in the repository now.

@aeneasr aeneasr closed this as completed in 95a51de Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants