Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables naming scheme #136

Closed
janekolszak opened this issue Jul 10, 2016 · 3 comments
Closed

Environment variables naming scheme #136

janekolszak opened this issue Jul 10, 2016 · 3 comments

Comments

@janekolszak
Copy link

Hi,
We can pass some data to hydra via environment variables - awesome and very useful for docker-compose deployment.

Shouldn't the env variables have a common prefix "HYDRA_" to avoid collisions?

@aeneasr
Copy link
Member

aeneasr commented Jul 10, 2016

Good point, that really depends on the environment. In a docker environment, there should be close to zero collisions, because you set env vars per container. Some of the env vars like PORT and HOST are actually best practice because they make hydra run on heroku/cloud foundry/flynn/dokku/... out of the box.

However, stuff like tls paths could be scoped - did name collision happen in your environment?

@janekolszak
Copy link
Author

Well if your container has only Hydra inside then you're right.

@aeneasr
Copy link
Member

aeneasr commented Jul 13, 2016

You can also set env vars with ENV=foo hydra - so i think we should be good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants