Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated hydra PHP composer package #1382

Closed
DASPRiD opened this issue Apr 23, 2019 · 5 comments
Closed

Outdated hydra PHP composer package #1382

DASPRiD opened this issue Apr 23, 2019 · 5 comments

Comments

@DASPRiD
Copy link
Contributor

DASPRiD commented Apr 23, 2019

Currently the latest version of the Hydra SKK in packagist v1.0.0-rc.6+oryOS.10, while the current Hydra release is at rc.9. Since meanwhile at least one API endpoint changed, the old SDK is not working with rc.9 and should be updated.

By the way, how about splitting the SDKs into individual repositories, so when installing the PHP, JS or any other SDK it doesn't have to pull all the stuff it doesn't care about?

@lpotherat
Copy link

Hydra API libraries should be in separate repositories, it is weird to install the whole hydra sources to only get the rest api sdk.

@aeneasr
Copy link
Member

aeneasr commented Apr 25, 2019

The SDKs are packaged and the packaging removes unnecessary files - if not that's a bug (please file a separate issue). So I don't see the upside of pushing that to separate repositories which adds additional complexity for releases.

@aeneasr
Copy link
Member

aeneasr commented Apr 25, 2019

I'm assuming that composer doesn't work well with optional build tags (+oryOS.10). Since composer is fetching basically the git tag, and we git tag things properly, this really seems to be an issue with the version naming. What about trying to just get v1.0.0-rc.9 (without the oryOS part)?

@DASPRiD
Copy link
Contributor Author

DASPRiD commented Apr 25, 2019

No dice there. Packagist actually requires a trigger on your github repository to be informed about new tags. Maybe the trigger got disabled?

@aeneasr
Copy link
Member

aeneasr commented Apr 25, 2019

Yeah looks like the webhooks didn't work / weren't enabled. All tags should now be available again!

@aeneasr aeneasr closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants