Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSN credential is shown in log #1585

Closed
oligo opened this issue Sep 28, 2019 · 1 comment
Closed

DSN credential is shown in log #1585

oligo opened this issue Sep 28, 2019 · 1 comment

Comments

@oligo
Copy link

oligo commented Sep 28, 2019

Describe the bug

When hydra starts, it prints database connection information in the log. These log records have DSN info in them which keep the username and password unmasked.

Reproducing the bug

Steps to reproduce the behavior:

  1. Run hydra serve all with a MySQL DSN configured
  2. Check the server startup log.

Server logs

time="2019-09-28T02:42:37Z" level=info msg="Establishing connection with SQL database backend" dsn="username:password@tcp(dbip:3306)/hydradb?parseTime=true://*:*@tcp(dbip:3306)/hydradb?parseTime=true"
time="2019-09-28T02:42:37Z" level=info msg="Successfully connected to SQL database backend" dsn="username:password@tcp(dbip:3306)/hydradb?parseTime=true://*:*@tcp(dbip:3306)/hydradb?parseTime=true"

Expected behavior

The DSN username and password should not be shown in plaintext.

Environment

  • Version: v1.0.1+oryOS.12, 937cb2e
  • Environment: Docker
@aeneasr
Copy link
Member

aeneasr commented Sep 28, 2019

Thank you for reporting, this has been resolved in 1.0.2+

@aeneasr aeneasr closed this as completed Sep 28, 2019
@MDrollette MDrollette mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @oligo