Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: Different uuid for imported keys #1741

Closed
DennisPattmann5012 opened this issue Feb 26, 2020 · 5 comments
Closed

keys: Different uuid for imported keys #1741

DennisPattmann5012 opened this issue Feb 26, 2020 · 5 comments
Labels
feat New feature or request. help wanted We are looking for help on this one. stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@DennisPattmann5012
Copy link
Contributor

Not sure if it's a bug!

All keys generated by Hydra have the same UUID for private and public key. I imported a key-pair and the private and public key now have different UUIDs.

It this is the expected behavior feel free to close this issue. Otherwise I would like to open a PR.

Reproducing the bug

Steps to reproduce the behavior:

hydra keys import hydra.jwt.access-token ./priv.key ./pub.pub --endpoint XXXXXXXXX
hydra keys get hydra.jwt.access-token
@aeneasr
Copy link
Member

aeneasr commented Feb 26, 2020

I have to check, it's definitely a weird behavior. Did this cause any downstream bugs for you?

@DennisPattmann5012
Copy link
Contributor Author

At the moment I can't see any misbehavior, however, Hydra doesn't use the imported key to sign tokens.

I think the JWKHandler ImportKeys method should generate the uuid only once. (Line 143/145)

@aeneasr
Copy link
Member

aeneasr commented Feb 28, 2020

I see - let's change that then - would you be up for that? :)

Regarding key rotation: https://www.ory.sh/docs/hydra/advanced#key-rotation

@DennisPattmann5012
Copy link
Contributor Author

I will take care as soon as possible. :-)

@aeneasr aeneasr added the help wanted We are looking for help on this one. label Aug 20, 2020
@aeneasr aeneasr added this to the unplanned milestone Aug 20, 2020
@aeneasr aeneasr added the feat New feature or request. label Aug 20, 2020
@github-actions
Copy link

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. help wanted We are looking for help on this one. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants