Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flush refresh tokens for service oauth2/flush #2373

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

naveenpaul1
Copy link
Contributor

Related issue

This changes are done based on the discussion happend on thread https://github.com/ory/hydra/issues/1574#issuecomment-736684327

@aeneasr @Demonsthere

Proposed changes

flush expired refresh token along with access_token in /oauth2/flush service call, where condition remains same as access toke table deletion query

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thank you! @Benehiko can you take a look as well please?

What would be perfect as well would be a small test to check if the behaviour works as expected - you can probably add some code to this test: https://github.com/ory/hydra/blob/master/oauth2/handler_test.go#L131

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeneasr LGTM :)

@naveenpaul1
Copy link
Contributor Author

updated the PR with unit test for access token scenario.
@aeneasr @Benehiko : please review

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit b46a14c into ory:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants