Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support partial client updates #2385

Closed
mbonnell-wish opened this issue Mar 5, 2021 · 2 comments
Closed

feat: Support partial client updates #2385

mbonnell-wish opened this issue Mar 5, 2021 · 2 comments

Comments

@mbonnell-wish
Copy link
Contributor

mbonnell-wish commented Mar 5, 2021

Is your feature request related to a problem? Please describe.

Currently, the only client updates supported by the REST API are updates with PUT semantics, meaning the entire client gets replaced. This is undesirable when one only wants to update a certain property, like a callback URI.

This desire is referenced here and here.

Describe the solution you'd like

It would be good to also support partial client updates through a PATCH request. For the CLI, we could add some flag like --partial as suggested by @matheusfm.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've
considered.

Additional context

Would be happy to tackle this over the weekend.

@mattbonnell
Copy link
Contributor

@aeneasr let me know if you'd be open to accepting a PR for this feature 😄
Would be a little bit of work so just want to get the green-light from you before I start on it.

@aeneasr
Copy link
Member

aeneasr commented Mar 7, 2021

Yes, that would be great! There's an open issue for discussing ideas how to do this here: ory/meta#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants