fix: login and consent redirect behavior change since 1.9.x #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow #fragment in configured url to keep backwards compatibility. Close ory#2363
|
|
|
Could you please add a test case for this? :) |
|
Are you still up for the changes? :) If you need any help, let us know! |
aeneasr
added
the
pending reply
|
added tests to the branch. |
aeneasr
removed
the
pending reply
aeneasr
previously approved these changes
Apr 26, 2021
aeneasr
reviewed
Apr 27, 2021
mitar
pushed a commit
to mitar/hydra
that referenced
this pull request
May 13, 2021
Allow #fragment in configured url to keep backwards compatibility. Close ory#2363 Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow #fragment in configured url to keep backwards compatibility. Close #2363
Related issue
@aeneasr, this for keep backwards compatibility prior to v1.9.x.
Proposed changes
Since the login, consent urls are configured by server owner, redirect to login or consent ui built with SPA should be allowed, although not recommended.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments