Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public endpoints different than issuer #2462

Closed
ppawliczek opened this issue Apr 12, 2021 · 3 comments
Closed

Public endpoints different than issuer #2462

ppawliczek opened this issue Apr 12, 2021 · 3 comments
Labels
stale Feedback from one or more authors is required to proceed.

Comments

@ppawliczek
Copy link

Describe the bug

In the configuration there are parameters urls->self->public (URLS_SELF_PUBLIC) and urls->self->issuer (URLS_SELF_ISSUER). The former one is described as "This is the base location of the public endpoints of your ORY Hydra installation.". However, when I tried to set URLS_SELF_ISSUER to different value, the authorization and token endpoints reported in the metadata file (.../.well-known/openid-configuration) changes together with the "issuer" field (the parameter URLS_SELF_PUBLIC is ignored).

Expected behavior

I would expect that location of the endpoints is determined by URLS_SELF_PUBLIC, while the value of the issuer is determined by URLS_SELF_ISSUER.

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2021

Ah this looks like a regression from a recent patch we merged. You are correct, issuer should only be used for the issuer values. Would you be open to a PR?

@ppawliczek
Copy link
Author

#2441 should fix it

@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Apr 22, 2022
@aeneasr aeneasr closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants