Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link in documentation #2478

Merged
merged 2 commits into from
Apr 23, 2021
Merged

fix: link in documentation #2478

merged 2 commits into from
Apr 23, 2021

Conversation

Fantom409
Copy link
Contributor

Related issue

Proposed changes

Currently, I receive a 404 error if I want to be redirected to 'Login flow page' via this link, this PR fix it

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2021

CLA assistant check
All committers have signed the CLA.

@vinckr
Copy link
Member

vinckr commented Apr 19, 2021

Thanks a lot for looking into this!
Your fix works, but unfortunately it is linking to the wrong document then, not the "version-v.1.10" one, but the "next version" one.

I think you encountered this bug (ory/docs#563),
the correct fix would be to add the file extension to the link like so:
../concepts/login.mdx

If you could change that, would be stellar 🙏

I will make a note to go over the documentation and fix all those links 🙂

vinckr
vinckr previously approved these changes Apr 19, 2021
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks 🎉

@aeneasr
Copy link
Member

aeneasr commented Apr 19, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 5fdd913 into ory:master Apr 23, 2021
mitar pushed a commit to mitar/hydra that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants