Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make token user command work with public clients #2479

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

svrakitin
Copy link
Contributor

@svrakitin svrakitin commented Apr 20, 2021

Related issue

See thread: https://ory-community.slack.com/archives/C012RBW0F18/p1618883706197100

Proposed changes

  • Do not require client secret when running hydra token user making it work with public clients

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aeneasr
Copy link
Member

aeneasr commented Apr 22, 2021

Awesome, thank you!

@aeneasr aeneasr merged commit a033d6a into ory:master Apr 22, 2021
mitar pushed a commit to mitar/hydra that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants