refactor: move unix socket support helpers into ory/x #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloonz
changed the title
|
ory/x is merged and released! |
|
Updated ory/x to 0.0.222 in my branches, so it should now build correctly without having to add a manual replace in go.md |
|
Looks like there are still some build failures |
|
I forgot to move the unit tests of |
mitar
pushed a commit
to mitar/hydra
that referenced
this pull request
May 13, 2021
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
This has been discussed here with @aeneasr : ory/kratos#1249
Proposed changes
ory/x#328 moves some unix socket related helpers into ory/x ; this pull request aims to use them
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.