Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Valid JSON response for already handled requests #2517

Merged
merged 2 commits into from
May 4, 2021

Conversation

svrakitin
Copy link
Contributor

Related issue

Closes #2515

Proposed changes

  • Add missing returns to avoid writing response twice when getting requests.
  • Add missing tests to check that response is valid

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

I noticed that we do not expose client on logout requests, but it seems to be fixed by #2483

@aeneasr aeneasr merged commit ac61616 into ory:master May 4, 2021
@aeneasr
Copy link
Member

aeneasr commented May 4, 2021

Thank you!

@svrakitin svrakitin deleted the fix-gone-login-response branch May 4, 2021 13:51
mitar pushed a commit to mitar/hydra that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid json response with get login request
2 participants