fix: add the missing keys import command #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
approved these changes
May 10, 2021
|
Awesome, thank you! 🎉 Your contribution makes Ory better :) |
mitar
pushed a commit
to mitar/hydra
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#2520
Proposed changes
It looks like the
clientCmd.AddCommand(NewKeysImportCmd())line was missed during a recent refactor, I just added it.Checklist
Further comments
I looked briefly at adding tests but it looked like it would require some refactoring of the current strategy. If you would like me to look into it I can spend some time on it.