Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README exemplary apps #2579

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix: README exemplary apps #2579

merged 1 commit into from
Jun 21, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jun 21, 2021

Related issue

#2578

I didnt find the exemplary consent app in Go, (is it in https://github.com/ory/sdk/tree/master/clients/hydra/go ?)

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@mitar
Copy link
Contributor

mitar commented Jun 21, 2021

Yea, I was searching primarily for Go.

@aeneasr
Copy link
Member

aeneasr commented Jun 21, 2021

There is no such app for go unfortunately

@aeneasr aeneasr merged commit 60e7042 into ory:master Jun 21, 2021
@@ -26,8 +26,7 @@ ORY Hydra is a hardened, **OpenID Certified OAuth 2.0 Server and OpenID Connect
and low resource consumption. ORY Hydra *is not* an identity provider (user sign up, user login, password reset flow),
but connects to your existing identity provider through a [login and consent app](https://www.ory.sh/docs/next/hydra/oauth2#authenticating-users-and-requesting-consent).
Implementing the login and consent app in a different language is easy, and exemplary consent apps
([Go](https://github.com/ory/hydra-consent-app-go), [Node](https://github.com/ory/hydra-consent-app-express)) and
[SDKs](https://www.ory.sh/docs/next/hydra/sdk/) are provided.
([Node](https://github.com/ory/hydra-login-consent-node)) and [SDKs](https://www.ory.sh/docs/next/hydra/sdk/) for all common languages are provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, if there is only one example app which exists, maybe it should not say "exemplary consent apps". :-)

@vinckr vinckr mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants