Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad HTML encoding of the scope parameter #259

Closed
janekolszak opened this issue Sep 20, 2016 · 3 comments
Closed

Bad HTML encoding of the scope parameter #259

janekolszak opened this issue Sep 20, 2016 · 3 comments
Assignees
@aeneasr
Labels
bug Something is not working.
Milestone
0.5.0

Comments

@janekolszak
Copy link

Hi
There seems to be a bug in passing the scope param in the id_token token response.
I requested openid all scopes and the respoinse url had openid%252Ball.

So you're html encoding the + sign. I think you should be html encoding only the names of the scopes (if any encoding is needed at all)
@aeneasr aeneasr added the bug Something is not working. label Sep 20, 2016
@aeneasr
Copy link
Member

aeneasr commented Sep 20, 2016

Thanks for reporting

@aeneasr aeneasr added this to the 0.5.0 milestone Sep 20, 2016
@aeneasr aeneasr self-assigned this Sep 21, 2016
@aeneasr aeneasr mentioned this issue Sep 21, 2016
Closed
@aeneasr
Copy link
Member

aeneasr commented Sep 21, 2016

upstream ory/fosite#95

@aeneasr
Copy link
Member

aeneasr commented Sep 21, 2016

resolved in ory/fosite@ddd8d03

@aeneasr aeneasr closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working.
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@janekolszak @aeneasr