Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider extract Go SDK package into separate repository #266

Closed
nikolay-turpitko opened this issue Sep 28, 2016 · 2 comments
Closed

Consider extract Go SDK package into separate repository #266

nikolay-turpitko opened this issue Sep 28, 2016 · 2 comments

Comments

@nikolay-turpitko
Copy link

SDK package now is a directory in the Hydra project. This is not very convenient to be used with go get, glide get, etc. SDK depends on several other packages within Hydra repository and adds some other transitive dependencies, which are unnecessary to a simple task of sending HTTP request to Hydra server. Effectively, when we use glide for dependency management, we have to add whole Hydra as a dependency of the client app. Please, consider to extract Hydra Go SDK to separate repo.

@aeneasr
Copy link
Member

aeneasr commented Sep 28, 2016

Thanks for the feedback, unfortunately this is currently not an option as the SDK will always depend on the basic hydra code. This is owed to the fact that hydra comes with HTTP clients for all endpoints which are well integrated in the testing suite. Redoing this in a different code base is prone to errors caused by api changes as well as more work to maintain.

I think that glide is exactly the right tool for this sort of issue, as you do not need to commit the vendor directory any more to get reproducible builds. Additionally, glide install times are, even for larger projects, quite speedy.

Once #249 lands, you might be able to fallback to autogenerated code, but before that I don't see this being done by our organization.

@aeneasr aeneasr closed this as completed Sep 28, 2016
@nikolay-turpitko
Copy link
Author

Well, OK. #249 is an interesting approach, might be a good alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants