Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing stack traces #2858

Merged
merged 3 commits into from
Nov 22, 2021
Merged

fix: missing stack traces #2858

merged 3 commits into from
Nov 22, 2021

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Nov 15, 2021

Missing strack traces I noticed.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@mitar mitar requested a review from aeneasr as a code owner November 15, 2021 14:07
@mitar mitar changed the title bug: missing stack traces fix: missing stack traces Nov 15, 2021
aeneasr
aeneasr previously approved these changes Nov 15, 2021
@aeneasr
Copy link
Member

aeneasr commented Nov 15, 2021

Looks like files unrelated to your change need formatting to get the CI to pass. Can you please run make format in the project's root? Thanks!

@mitar
Copy link
Contributor Author

mitar commented Nov 16, 2021

Done. I hope.

@aeneasr aeneasr merged commit 1441658 into ory:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants