Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed error handling in persister #2860

Merged
merged 5 commits into from
Nov 22, 2021
Merged

fix: fixed error handling in persister #2860

merged 5 commits into from
Nov 22, 2021

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Nov 16, 2021

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@mitar mitar requested a review from aeneasr as a code owner November 16, 2021 11:40
@mitar
Copy link
Contributor Author

mitar commented Nov 16, 2021

I also noticed duplicated code, so I removed that.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking good, just a minor change

persistence/sql/persister_oauth2.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #2860 (6e0c693) into master (f15f339) will decrease coverage by 0.05%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
- Coverage   49.87%   49.82%   -0.06%     
==========================================
  Files         236      236              
  Lines       14974    14958      -16     
==========================================
- Hits         7469     7453      -16     
  Misses       6843     6843              
  Partials      662      662              
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 81.70% <61.53%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511a668...6e0c693. Read the comment docs.

@aeneasr aeneasr merged commit 33d75d7 into ory:master Nov 22, 2021
@aeneasr
Copy link
Member

aeneasr commented Nov 22, 2021

🙏

@mitar mitar deleted the patch-2 branch November 22, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants