Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use Ory instead of ORY in the documentation #2939

Merged
merged 2 commits into from
Jan 15, 2022
Merged

docs: use Ory instead of ORY in the documentation #2939

merged 2 commits into from
Jan 15, 2022

Conversation

gen1us2k
Copy link
Contributor

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Update Ory Hydra documentation to follow styleguide

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2939 (949af0b) into master (5a4e11c) will not change coverage.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2939   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files         113      113           
  Lines        8054     8054           
=======================================
  Hits         6424     6424           
  Misses       1223     1223           
  Partials      407      407           
Impacted Files Coverage Δ
cmd/cli/handler.go 89.47% <0.00%> (ø)
cmd/clients.go 100.00% <100.00%> (ø)
cmd/clients_create.go 100.00% <100.00%> (ø)
cmd/keys.go 100.00% <100.00%> (ø)
cmd/root.go 91.30% <100.00%> (ø)
cmd/serve.go 100.00% <100.00%> (ø)
cmd/server/banner.go 100.00% <100.00%> (ø)
cmd/token_client.go 86.00% <100.00%> (ø)
cmd/token_delete.go 100.00% <100.00%> (ø)
cmd/token_flush.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4250f03...949af0b. Read the comment docs.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!
Looking good 🎉
The docs under /cli have to be changed elsewhere, it will be overwritten.
Here you can find the CLI doc for hydra clients create for example:
https://github.com/ory/hydra/blob/master/cmd/clients_create.go

@gen1us2k
Copy link
Contributor Author

Okay. I'll fix it soon

@gen1us2k gen1us2k requested a review from aeneasr as a code owner January 14, 2022 10:33
@gen1us2k
Copy link
Contributor Author

@vinckr I changed style in cmd folder. I think it can be a good idea(to change ORY to Ory in the whole project automatically using grep+sed). What do you think?

@aeneasr aeneasr merged commit 1b2f6a6 into ory:master Jan 15, 2022
@aeneasr
Copy link
Member

aeneasr commented Jan 15, 2022

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants