Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure audit logger #3022

Merged
merged 1 commit into from
Mar 4, 2022
Merged

fix: configure audit logger #3022

merged 1 commit into from
Mar 4, 2022

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Mar 4, 2022

Related issue(s)

Closes #3021

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Previously the audit logger did not pick up the configuration.

@zepatrik zepatrik requested a review from aeneasr as a code owner March 4, 2022 09:40
@zepatrik
Copy link
Member Author

zepatrik commented Mar 4, 2022

We still need hot-reloading though...
Actually not, log is immutable.

@aeneasr
Copy link
Member

aeneasr commented Mar 4, 2022

Actually, could you make this against hydra 2.0 branch?

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #3022 (1a46ac6) into master (510615b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3022   +/-   ##
=======================================
  Coverage   79.39%   79.40%           
=======================================
  Files         112      112           
  Lines        7888     7889    +1     
=======================================
+ Hits         6263     6264    +1     
  Misses       1223     1223           
  Partials      402      402           
Impacted Files Coverage Δ
driver/registry_base.go 88.96% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17b474...1a46ac6. Read the comment docs.

@zepatrik zepatrik merged commit 3115dde into master Mar 4, 2022
@zepatrik zepatrik deleted the fix/audit-logger-config branch March 4, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log.format: json - audit log messages are printed in plain text
2 participants