Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Synced ports between Dockerfiles and comments #3027

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Mar 5, 2022

Related: ory/docs#651

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@mitar mitar requested a review from aeneasr as a code owner March 5, 2022 05:47
@mitar mitar mentioned this pull request Mar 5, 2022
@mitar mitar changed the title Synced ports between Dockerfiles and comments fix: Synced ports between Dockerfiles and comments Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #3027 (1a1143c) into master (3115dde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3027   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files         112      112           
  Lines        7889     7889           
=======================================
  Hits         6266     6266           
  Misses       1222     1222           
  Partials      401      401           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff6491...1a1143c. Read the comment docs.

@grantzvolsky
Copy link
Contributor

+1

@aeneasr aeneasr merged commit ebd1694 into ory:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants