Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token_endpoint_auth_signing_alg to cli #3148

Merged
merged 2 commits into from
Jun 14, 2022
Merged

feat: add token_endpoint_auth_signing_alg to cli #3148

merged 2 commits into from
Jun 14, 2022

Conversation

sashamelentyev
Copy link
Contributor

@sashamelentyev sashamelentyev commented Jun 13, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security.
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@sashamelentyev sashamelentyev requested a review from aeneasr as a code owner June 13, 2022 14:34
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022

CLA assistant check
All committers have signed the CLA.

@sashamelentyev
Copy link
Contributor Author

#3025

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3148 (147cce5) into master (9902ec7) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 147cce5 differs from pull request most recent head a376325. Consider uploading reports for the commit a376325 to get more accurate results

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   79.55%   79.55%   -0.01%     
==========================================
  Files         112      112              
  Lines        7967     7971       +4     
==========================================
+ Hits         6338     6341       +3     
- Misses       1224     1225       +1     
  Partials      405      405              
Impacted Files Coverage Δ
cmd/cli/handler_client.go 28.90% <50.00%> (+0.24%) ⬆️
cmd/clients_create.go 100.00% <100.00%> (ø)
cmd/clients_update.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a75323...a376325. Read the comment docs.

@aeneasr aeneasr merged commit ed6eb30 into ory:master Jun 14, 2022
@vinckr
Copy link
Member

vinckr commented Jun 17, 2022

Hello @sashamelentyev
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants