Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport fix for client specific CORS (#1754) #3163

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

har07
Copy link
Contributor

@har07 har07 commented Jun 20, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security.
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@har07 har07 requested a review from aeneasr as a code owner June 20, 2022 04:21
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #3163 (513092a) into master (ed6eb30) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 513092a differs from pull request most recent head f7c0b01. Consider uploading reports for the commit f7c0b01 to get more accurate results

@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
- Coverage   79.55%   79.53%   -0.02%     
==========================================
  Files         112      112              
  Lines        7971     7973       +2     
==========================================
  Hits         6341     6341              
- Misses       1225     1226       +1     
- Partials      405      406       +1     
Impacted Files Coverage Δ
x/oauth2cors/cors.go 89.47% <100.00%> (+0.38%) ⬆️
persistence/sql/persister_oauth2.go 81.01% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96276...f7c0b01. Read the comment docs.

@aeneasr aeneasr merged commit 996258d into ory:master Jun 20, 2022
@aeneasr
Copy link
Member

aeneasr commented Jun 20, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants